# Feature (2943): Upload original sourceCode for java functions in poly java client #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly java client - Only source code pass to the poly function
aarongoin
reviewed
Nov 14, 2024
polyapi-maven-plugin/src/main/java/io/polyapi/plugin/service/DeploymentServiceImpl.java
Outdated
Show resolved
Hide resolved
Member
|
@eupharis Maybe you can weigh in here on what it takes to bump the version for the java client. I assume there must be something Sudip needs to change here in the repo? |
Member
|
@aarongoin @sudiptatj I am really not sure! But here's an old PR which looks like a promising template for updating the version number: https://github.com/polyapi/polyapi-java/pull/52/files I also have some credentials for logging in and actually deploying this somewhere. But I'm not 100% sure how that process works either! We will have to figure that out too! |
…ly java client - Source code will pass as string, not json stringify
…ly java client - Version updated - ChangeLog file added
Contributor
Author
|
@aarongoin Please have a look on your convenient time. |
aarongoin
approved these changes
Nov 20, 2024
Member
aarongoin
left a comment
aarongoin
left a comment
There was a problem hiding this comment.
Thanks, Sudip! Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue fix : https://github.com/polyapi/poly-alpha/issues/2943